Skip to content

RDKEMW-9893: set option to enable new dtags.#1605

Merged
magomez merged 1 commit intoWebPlatformForEmbedded:wpe-2.38from
lulicdarko:RDKEMW_9839_enable_new_dtags_2_38
Jan 26, 2026
Merged

RDKEMW-9893: set option to enable new dtags.#1605
magomez merged 1 commit intoWebPlatformForEmbedded:wpe-2.38from
lulicdarko:RDKEMW_9839_enable_new_dtags_2_38

Conversation

@lulicdarko
Copy link

@lulicdarko lulicdarko commented Jan 21, 2026

Added option to enable new dtags.

Explanation:
This change introduces a Cmake option ENABLE_NEW_DTAGS to allow to use --enable-new-dtags for WPE Webkit build.
Primary goal is to force the linker to use DT_RUNPATH instead of legacy DT_RPATH. This change is important because:

  1. DT_RUNPATH respects LD_LIBRARY_PATH unlike older DT_RPATH
  2. This allows us to override system libraries or redirect library lookup at runtime without re-linkiing the entire Webkit.

Changes:

  • Source/cmake/OptionsCommon.cmake

@lulicdarko lulicdarko mentioned this pull request Jan 21, 2026
Closed
@magomez magomez self-requested a review January 22, 2026 11:50
magomez
magomez requested changes Jan 22, 2026
View reviewed changes
Copy link

@magomez magomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments than in #1603

@lulicdarko
Copy link
Author

lulicdarko commented Jan 22, 2026

Same comments than in #1603

It is same since it is doing exactly same as #1603 but for different webkit version. What exactly i need to change in comment.

@magomez
Copy link

magomez commented Jan 22, 2026

Same comments than in #1603

It is same since it is doing exactly same as #1603 but for different webkit version. What exactly i need to change in comment.

Yes, I know it's the same patch than #1603 but applied to 2.38. What I mean is that the review comments for this PR are the same than those I added to #1603.

@lulicdarko
Copy link
Author

lulicdarko commented Jan 22, 2026

Same comments than in #1603

It is same since it is doing exactly same as #1603 but for different webkit version. What exactly i need to change in comment.

Yes, I know it's the same patch than #1603 but applied to 2.38. What I mean is that the review comments for this PR are the same than those I added to #1603.

Got it, thanks.

@lulicdarko lulicdarko force-pushed the RDKEMW_9839_enable_new_dtags_2_38 branch from ad5c94e to 2047ee4 Compare January 26, 2026 09:31
@lulicdarko
Copy link
Author

lulicdarko commented Jan 26, 2026

Same comments than in #1603

It is same since it is doing exactly same as #1603 but for different webkit version. What exactly i need to change in comment.

Yes, I know it's the same patch than #1603 but applied to 2.38. What I mean is that the review comments for this PR are the same than those I added to #1603.

Got it, thanks.

Hello @magomez I did update regarding comments.

@magomez magomez merged commit 2419a7e into WebPlatformForEmbedded:wpe-2.38 Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magomez magomez magomez approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lulicdarko @magomez